fix: open target URLs in default browser when running standalone PWA#1
Open
simpgps wants to merge 3 commits into
Open
fix: open target URLs in default browser when running standalone PWA#1simpgps wants to merge 3 commits into
simpgps wants to merge 3 commits into
Conversation
Owner
Author
|
I am a human who is writing this comment, not an AI. |
Use x-safari-https/http on iOS standalone PWAs instead of window.open, which only opens the in-app browser without Safari UI. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes trovu#329.
When Trovu is run as a standalone PWA, redirecting search targets via
window.location.hreftraps the user inside the PWA container.Opening a new tab via
window.openafter anawaitstatement is blocked by browser popup blockers because the transient user activation context is lost across asynchronous boundaries.This PR resolves this by opening a blank window (
about:blank) synchronously inside the user gesture event handler, and subsequently redirecting it to the target URL once resolved, or closing it if redirection is aborted./claim trovu#329